Skip to content

MQE-980: <features> tag defaults to module #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2018
Merged

MQE-980: <features> tag defaults to module #125

merged 6 commits into from
May 9, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Merged tests now contain comma separated list of files where they came from (no longer overwritten)
  • Generated tests completely override the @Features annotations given, prefering the Module Name

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-980: [Annotations] <features> tag defaults to module
6a94c87 
- Dom no longer overwrites filename, instead builds comma separated list to keep track of all test and merge paths
- TestObjectExtractor not extracts module form base test path, and overwrites testAnnotations["features"] to only include the single module name.
- Unit/Verification updates.
@KevinBKozan
MQE-980: [Annotations] <features> tag defaults to module
f0201e5 
- CR Fixes
@KevinBKozan
MQE-980: [Annotations] <features> tag defaults to module
091b10e 
- CR fixes, test updates
@KevinBKozan
Merge branch 'develop' into MQE-980
e386744
@KevinBKozan
MQE-980: [Annotations] <features> tag defaults to module
ec5d25a 
- CR Fixes.
@KevinBKozan
MQE-980: [Annotations] <features> tag defaults to module
3a07785 
- Test Fix
@coveralls
Copy link

coveralls commented May 9, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 56.882% when pulling 3a07785 on MQE-980 into 097ebe8 on develop.

@imeron2433 imeron2433 merged commit 48bbdb6 into develop May 9, 2018
@imeron2433 imeron2433 deleted the MQE-980 branch May 9, 2018 16:02
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 13, 2021
@okolesnyk
Merge pull request #125 from magento-commerce/MQE-3006
c565c45 
MQE-3006: Repo Metadata - Remove Email/Add DL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @imeron2433